Skip to content

fix: prevent validation project from being packaged#270

Merged
j-d-ha merged 1 commit into
mainfrom
fix/set-validation-project-not-to-be-packed
Dec 22, 2025
Merged

fix: prevent validation project from being packaged#270
j-d-ha merged 1 commit into
mainfrom
fix/set-validation-project-not-to-be-packed

Conversation

@j-d-ha

@j-d-ha j-d-ha commented Dec 22, 2025

Copy link
Copy Markdown
Collaborator

🚀 Pull Request

📋 Summary

Adds <IsPackable>false</IsPackable> to the AotCompatibility.TestApp project to prevent it from being packaged for NuGet distribution. This project is used solely for AOT compatibility validation during the build process and should not be published as a package.


✅ Checklist

  • My changes build cleanly
  • I've added/updated relevant tests
  • I've added/updated documentation or README
  • I've followed the coding style for this project
  • I've tested the changes locally (if applicable)

🧪 Related Issues or PRs

N/A - Housekeeping fix to ensure validation project isn't packaged.


💬 Notes for Reviewers

This is a simple one-line change to prevent the AOT compatibility test application from being published as a NuGet package. The project is only used for build-time validation of AOT compatibility and should not be distributed.

- Set IsPackable to false to prevent the project from being included in NuGet package creation.
@github-actions github-actions Bot added the type: fix Bug fix label Dec 22, 2025
@j-d-ha j-d-ha changed the title fix(AotCompatibility.TestApp): prevent validation project from being packaged fix: prevent validation project from being packaged Dec 22, 2025
@sonarqubecloud

Copy link
Copy Markdown

@j-d-ha
j-d-ha enabled auto-merge (squash) December 22, 2025 00:39
@j-d-ha
j-d-ha merged commit a4dbd43 into main Dec 22, 2025
6 of 7 checks passed
@j-d-ha
j-d-ha deleted the fix/set-validation-project-not-to-be-packed branch December 22, 2025 00:40
@codecov

codecov Bot commented Dec 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #270   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files         132      132           
  Lines        3270     3270           
  Branches      324      324           
=======================================
  Hits         2907     2907           
  Misses        247      247           
  Partials      116      116           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d60503...9b8ab6d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant